]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
animation: Don't sync animation sizes on change
authorMarco Trevisan (Treviño) <mail@3v1n0.net>
Fri, 14 Jun 2019 14:44:19 +0000 (17:44 +0300)
committerFlorian Müllner <florian.muellner@gmail.com>
Wed, 16 Oct 2019 15:26:12 +0000 (15:26 +0000)
When the actor size changes, we might incur into an allocation cycle.

This was introduced by commit b6ec02ce, but when the animation will be an actor
itself, there will be no need to update the children size on actor size update,
as this will be managed by the actor allocation cycle itself.

Fixes: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1384
https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/559

js/ui/animation.js

index 18c837e822ab6086f4208d122bb84104a34c9777..3ad1358d57f16bd904facdd2ccdbdf0af83ec5a7 100644 (file)
@@ -12,7 +12,6 @@ var Animation = class {
         this.actor = new St.Bin();
         this.actor.set_size(width, height);
         this.actor.connect('destroy', this._onDestroy.bind(this));
-        this.actor.connect('notify::size', this._syncAnimationSize.bind(this));
         this.actor.connect('resource-scale-changed',
             this._loadFile.bind(this, file, width, height));